duplicate app-icon badge counter to chat's tab-bar-item #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/chats-unread-badge
branch
3 times, most recently
from
0b6d175 to
3d9d7ac
Compare
r10s
force-pushed
the
r10s/chats-unread-badge
branch
from
3d9d7ac to
4362392
Compare
r10s
force-pushed
the
r10s/chats-unread-badge
branch
2 times, most recently
from
e42140b to
dedf1b0
Compare
both badge counters will show the same number in the same layout. if notifications are disabled, both counters are hidden (the badges beside chats stay) in practise, this feels totally normal and correctly, this behavior is known from many other apps on iOS. this also resets the counter on app start, maybe fixing some rare bugs where the counter is wrong on the app icon
r10s
force-pushed
the
r10s/chats-unread-badge
branch
from
dedf1b0 to
cdd6b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it easier to notice new messages,
this PR shows the number of unread messages in the chat's tab-bar item -
and not only on the app-icon on the homescreen.
this is esp. useful as tapping the icon scrolls up now,
giving users and intuitive way to get to the new chats.
both badge counters will show the same number in the same layout.
if notifications are disabled, both counters are hidden
(the badges beside chats stay)
in practise, this feels totally normal and correctly,
this behavior is known from many other apps on iOS.
(i was also trying to show only the number of the active account,
that is more confusing, also in some tiny tests with some ppl.
i also tried other colors, but the default color seems the way to go here)
this also resets the counter on app start,
maybe fixing some rare bugs where the counter is wrong on the app icon
closes #2130
note, that the badge counters are not strictly event driven as they may be updates also when the app is not running by the NSE