for chatmail accounts, hide some not useful settings #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM. From what I understand, this requires to update the core-dependency, right?
Oh, and I just saw this message in the Xcode console:
🧡 [1] deltachat-ffi/src/lib.rs:285: dc_get_config(): invalid key 'is_chatmail'
This probably says that I didn't update core, right?
as 'Show Email' has randomly the value 0, which is the same iOS assignes by default, tapping on some switch cells opens 'Show Email'. we fix this by explicitly adding a defaultTagValue that is zero.
core was not updated on the |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
counterpart of deltachat/deltachat-android#3050 , see there for discussion and reasoning
this is how the advanced settings look like now: left classicmail, right chatmail ... so much cleaner :)