notify reactions added #2331
Merged
notify reactions added #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/notify-reactions
branch
from
d7b19d0 to
d770563
Compare
r10s
force-pushed
the
r10s/notify-reactions
branch
from
8c50d49 to
fdc0ac7
Compare
r10s
added
wait-for-core
r10s
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Oct 21, 2024
this PR adds an event for reactions received for one's own messages. this will allow UIs to add notification for these reactions. **Screenshots** at deltachat/deltachat-ios#2331: --------- Co-authored-by: iequidoo <[email protected]>
r10s
force-pushed
the
r10s/notify-reactions
branch
from
fdc0ac7 to
6718fe4
Compare
|
at the latest, when this gets merged, file issues for android/desktop |
r10s
force-pushed
the
r10s/notify-reactions
branch
from
6718fe4 to
b69ade3
Compare
r10s
added
the
wait-for-merge-window
|
we should not merge this PR until we have an answer to the multi-device question at deltachat/deltachat-android#3377 (review) |
r10s
force-pushed
the
r10s/notify-reactions
branch
2 times, most recently
from
67a1dcf to
835079b
Compare
r10s
removed
the
wait-for-merge-window
r10s
force-pushed
the
r10s/notify-reactions
branch
from
835079b to
53d0ab4
Compare
adbenitez
approved these changes
Nov 23, 2024
adbenitez
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR shows notifications for reactions to one's own messages.
requires a core with deltachat/deltachat-core-rust#6072
this is how it looks like on the lock screen:
the accumulation is done when we discover multiple messages/reaction when processing a PUSH notification in the "notification service extension", where we can only modify the single, given notification, but not add additional ones (often, this accumulation is not needed, as PUSH notifications receive in time and one-per-one)