Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Proxy-URLs and handle them #2396

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Detect Proxy-URLs and handle them #2396

merged 5 commits into from
Nov 15, 2024

Conversation

zeitschlag
Copy link
Collaborator

@zeitschlag zeitschlag commented Nov 14, 2024 •
edited
Loading

  • Detect Proxy-URLs in both Chats and Contact-details.
  • When tapping on them, the user sees an alert so that it doesn't get activated accidentally.

2389

@zeitschlag zeitschlag self-assigned this Nov 14, 2024
@zeitschlag zeitschlag linked an issue Nov 14, 2024 that may be closed by this pull request
Proxy: Detect Proxy-URLs in Chat-messages and Account-Notes #2389
Closed
@zeitschlag zeitschlag changed the title 2389 detect proxy urls Detect Proxy-URLs and handle them Nov 14, 2024
@zeitschlag zeitschlag marked this pull request as ready for review November 14, 2024 16:41
@zeitschlag zeitschlag requested a review from r10s November 14, 2024 16:41
r10s
r10s approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a minor, in general, works as expected

deltachat-ios/Chat/ChatViewController.swift Outdated Show resolved Hide resolved
deltachat-ios/Controller/ContactDetailViewController.swift Outdated Show resolved Hide resolved
@r10s r10s added the enhancement actually in development, user visible enhancement label Nov 14, 2024
@zeitschlag zeitschlag merged commit fee6102 into main Nov 15, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2389-detect-proxy-urls branch November 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees

@zeitschlag zeitschlag

Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy: Detect Proxy-URLs in Chat-messages and Account-Notes
2 participants
@zeitschlag @r10s