fix proxies added doubles sometimes #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core normalizes proxy-url when calling `set_config_from_qr(URL_ORG)`. by calling `set_config(URL_ORG)` instead of `URL_NORM=get_config()` after adding, we discarded the normalisation. when selecting later by `set_config_from_qr(URL_ORG)` finally results in `URL_ORG` as well as `URL_NORM` being added to the list. one could argue, that normalisation should also take place at `set_config()`, however, this is not the case. it also seems more resilient to refresh the list on adding, so that really the state and the URLs used on core are shown.
zeitschlag
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes the duplicated proxy entries mentioned at #2388 (review) - we first thought it is a core-bug, but eventually was not.
this was a hard to find bug ... i hope i could explain it correctly :)
core normalizes proxy-url
when calling
set_config_from_qr(URL_ORG).by calling
set_config(URL_ORG)instead ofURL_NORM=get_config()after adding, we discarded the normalisation.selecting later by
set_config_from_qr(URL_ORG)finally results inURL_ORGas well asURL_NORMbeing added to the list.one could argue,
that normalisation should also take place at
set_config(), however, this is not the case.it also seems more resilient to refresh the list on adding, so that really the state and the URLs used on core are shown.