-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new webxdc APIs #2412
Merged
Merged
add new webxdc APIs #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
r10s/adapt-to-m2m3-apis
branch
from
November 23, 2024 22:05
e75aae3
to
52c4685
Compare
Amzd
reviewed
Nov 25, 2024
Caspar, thanks joining the discussion from a general web-app/server angle!
What is different with webxdc apps and how clicking an info message opens a href
is that there is not neccessarily a "current" page as the info message might be
a historic message and you have since navigated the app to a different page.
So if the href is simply "#something" then the messenger would have a hard
time providing the implicit full location when starting the webview.
This is different with classic web-apps where a href is always used
within some current page/context and resolved relative to it.
…On Mon, Nov 25, 2024 at 05:47 -0800, adb wrote:
@adbenitez commented on this pull request.
> + let file = if let href {
+ if href.starts(with: "#") {
+ "index.html" + href
+ } else {
+ href
+ }
+ } else {
+ "index.html"
+ }
e.i. the #fragment is not relative to the current open page, otherwise the behavior would be arbitrary receiving a #fragment in the current open page when it was intended for another subpage
|
Amzd
reviewed
Nov 26, 2024
Amzd
reviewed
Nov 26, 2024
Co-authored-by: Casper Zandbergen <[email protected]>
Amzd
approved these changes
Nov 26, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2411