Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dedicated dark mode and tinted app icons #2425

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Conversation

r10s
Copy link
Member

@r10s r10s commented Dec 3, 2024

this PR adds dedicated dark-mode and tinted-mode icons, preserving the overall look of both, system and our logo:

   

the bubble in the dark mode is slightly lighter than in light mode, otherwise it would not contrast to the system-defined icon background (we left that so that it fits nicely to iOS style). i also tried the bordered-logo for dark mode, but that looked, well, not soooo smart. same when trying to make the bubble a stencil, so that the "δ" would be dark

and, of course, here are the NERD modes:

   

technically, imu according to https://developer.apple.com/documentation/xcode/configuring-your-app-icon it is sufficient for iOS to add a 1024 x 1024 icon to Xcode; the various old images in different resolutions are cleaned up by this PR

closes #2422

cmp https://mastodon.social/@r10s/113591229475718390

@r10s r10s requested review from zeitschlag and adbenitez December 3, 2024 20:46
@r10s r10s force-pushed the r10s/dark-mode-icon branch from 4bbf009 to d9a4703 Compare December 3, 2024 22:07
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (literally :D)

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: zeitschlag <[email protected]>
@r10s r10s merged commit 25b3806 into main Dec 5, 2024
1 check passed
@r10s r10s deleted the r10s/dark-mode-icon branch December 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dark mode icon
2 participants