Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning: handle new authorization status 'limited' #2444

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

r10s
Copy link
Member

@r10s r10s commented Dec 17, 2024

update to xcode 16 raises some new warnings; this PR fixes one of them:

  • if we get the authorization status 'limited' for accessing contacts, we're done - it is totally fine if the user does not give us access to all contacts

to not let CI fail with "unknown identified", this PR lets CI use Xcode 16 as well

@r10s r10s added the bug label Dec 17, 2024
@r10s r10s requested a review from zeitschlag December 17, 2024 22:48
Copy link
Collaborator

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you noticed that #2418 also updates the CI to use Xcode 16? So this will be a merge conflict. That's the price for PRs that have been open for quite some time 🙃

@r10s
Copy link
Member Author

r10s commented Dec 18, 2024

ah, then let's see who comes first in :)

no big deal, that is fixable by a small rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants