remove email-address unconditionally from title #2447
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the email-address was removed for guaranteed-e2ee chats quite a while ago (deltachat/deltachat-android#2916) reason was, among others, that these addresses are often chatmail and therefore random. (despite expecting otherwise, that was fine for most users). this PR removes the email-adress unconditionally: - having the email-address sometimes shown and sometimes not is confusing, and easily looks like a bug. this has become worse with the added vcard-support (before, there were rare non-guaranteed chats in chatmail) - resulting in more random addresses being shown - _always_ protect against over-the-shoulder attacks - better privacy in screenshots sent around without thinking much before (cmp. #2329) - wrt impersonation attacks: the pure email address in the subtitle did never protect against impersonation, one could always get sth. trustworthy looking there, it is better to check the profile with additional information (eg. other chats) if in doubt - general cleaner, uncluttered layout - pave the way of the upcoming multi-addresses drawback is that sometimes one more tap is needed to access the email-address - however, as it is _always_ one tap away now, this can also go easily to the finger memory.
zeitschlag
approved these changes
Dec 18, 2024
|
thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was discussed in-person with various ppl on the last physical gathering :)
the email-address was removed for guaranteed-e2ee chats quite a while ago (deltachat/deltachat-android#2916) reason was, among others, that these addresses are often chatmail and therefore random. (despite expecting otherwise, that was fine for most users).
this PR removes the email-adress unconditionally:
having the email-address sometimes shown and sometimes not is confusing, and easily looks like a bug. this has become worse with the added vcard-support (before, there were rare non-guaranteed chats in chatmail) - resulting in more random addresses being shown
always protect against over-the-shoulder attacks
better privacy in screenshots sent around without thinking much before (cmp. Better privacy in screenshots #2329)
wrt impersonation attacks: the pure email address in the subtitle did never protect against impersonation, one could always get sth. trustworthy looking there, it is better to check the profile with additional information (eg. other chats) if in doubt
general cleaner, uncluttered layout
pave the way of the upcoming multi-addresses
drawback is that sometimes one more tap is needed to access the email-address - however, as it is always one tap away now, this can also go easily to the finger memory.
counterpart of deltachat/deltachat-android#3507