fix & tweak forwarding #2607
Merged
fix & tweak forwarding #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does not make sense, however, would also not be worse than having RelayHelper setup half. (we leave checking also for empty text etc. up to the caller)
meanwhile, we have an explicit shortcut, so it seems reasonable to not differ otherwise for a now rarely used function.
r10s
force-pushed
the
r10s/tweak-forwarding
branch
from
6f29df2 to
08cc453
Compare
adbenitez
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR tweaks some minor bugs when forwarding messages, most importantly, the correctly filtered list is shown instantly.
see commits for more details.
closes #2436