Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core to 1.120.0 #126

Closed
wants to merge 1 commit into from
Closed

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Sep 6, 2023

No description provided.

@link2xt link2xt force-pushed the link2xt/core-1.120.0 branch from fc33a47 to 2cd76a9 Compare September 6, 2023 22:55
@link2xt link2xt marked this pull request as draft September 6, 2023 23:51
@link2xt
Copy link
Contributor Author

link2xt commented Sep 6, 2023

Currently the test tests/test_bot.py::TestSupportGroup::test_support_group_relaying fails.

There is a strange line in the log:

4.10 [events] INFO src/chat.rs:288: Created group/mailinglist '[email protected] support group' grpid=4qTKWbiVT7J as Chat#12, blocked=Yes.

This log comes from the admin account (there is such chat 12 in botadmin.db at the end of the test). Somehow the chat is created blocked (Blocked::Yes, not even Blocked::Request).

Also 1:1 chat with the bot is blocked in the bot admin database (also Yes, not just Request). Bot contact is fine, not blocked.
I have looked into admbot.db, and the bot has 1:1 chat with [email protected] blocked (1 aka Yes, not 2 aka Request). 1:1 chats being blocked seems to be expected, this is needed to hide system messages about securejoin that go to 1:1 chat when joining a group:
https://github.com/deltachat/deltachat-core-rust/blob/4d74f625d3962877a7462eec86f894d9c3bd68ea/src/securejoin/bob.rs#L33-L42

But the group chat getting blocked in the admin database is wrong.

I now suspect the change deltachat/deltachat-core-rust#4316 which got into the core 1.113.0. This is why we are stuck at the core 1.112.7 and cannot upgrade further.

@link2xt
Copy link
Contributor Author

link2xt commented Sep 7, 2023

I have created a core issue for this: deltachat/deltachat-core-rust#4690

UPD: core 1.122.0 has this bug fixed, once it is pushed to PyPI we can update to it.

@link2xt
Copy link
Contributor Author

link2xt commented Sep 13, 2023

Replaced with #128

@link2xt link2xt closed this Sep 13, 2023
@link2xt link2xt deleted the link2xt/core-1.120.0 branch September 13, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant