Skip to content

Commit

Permalink
updated changes according to comments from ben
Browse files Browse the repository at this point in the history
  • Loading branch information
maisnamraju committed Jul 8, 2021
1 parent bcd11f0 commit 2d4c6bc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions server/hooks.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@ func (p *Plugin) UserHasJoinedTeam(c *plugin.Context, teamMember *model.TeamMemb
}

for _, message := range p.getWelcomeMessages() {
if message.TeamName == data.Team.Name {
switch message.TeamName {
case data.Team.Name:
go p.processWelcomeMessage(*data, *message)
} else if message.TeamName == "*" {
case "*":
go p.processWelcomeMessage(*data, *message)
default:
p.API.LogError("Couldn't find the message for the team")
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion server/welcomebot.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func (p *Plugin) newSampleMessageTemplate(teamName, userID string) (*MessageTemp
return nil, fmt.Errorf("failed to query user %s: %w", userID, err)
}

if data.Team, err = p.API.GetTeamByName(strings.ToLower(teamName)); err != nil {
if data.Team, err = p.API.GetTeamByName(teamName); err != nil {
p.API.LogError("failed to query team", "team_name", teamName, "err", err)
return nil, fmt.Errorf("failed to query team %s: %w", teamName, err)
}
Expand Down

0 comments on commit 2d4c6bc

Please sign in to comment.