Skip to content

Update microsoft-auth-guide.md #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
noydavidi merged 34 commits into from
Oct 23, 2025
Merged

Update microsoft-auth-guide.md #1809

noydavidi merged 34 commits into from
Oct 23, 2025

Conversation

@noydavidi
Copy link
Contributor

@noydavidi noydavidi commented Oct 15, 2025

Related Issues

fixes: link to the issue

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

7 similar comments
@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 15, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 16, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
talihaff
talihaff reviewed Oct 22, 2025
View reviewed changes
@talihaff
Copy link
Contributor

talihaff commented Oct 22, 2025

@MLainer1 I noticed that the numbering in this section is inconsistent, which makes it hard to follow the sequence of steps. Additionally, it’s not very clear when a process starts or ends. Could we review this to improve clarity and make the flow more intuitive for the user?
In the meantime adding the label docs approved

@noydavidi
Copy link
Contributor Author

noydavidi commented Oct 22, 2025

@talihaff
Thank you for the doc review!
I committed the changes you suggested and I fixed the sections numbers, also used letters where needed. Thanks again.

@content-bot
Copy link
Collaborator

content-bot commented Oct 22, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

4 similar comments
@content-bot
Copy link
Collaborator

content-bot commented Oct 22, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 22, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 22, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@content-bot
Copy link
Collaborator

content-bot commented Oct 22, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

Shellyber
Shellyber approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!
See my comments before merge

content-repo/extra-docs/articles/microsoft-auth-guide.md

# Authentication Flows

:::info Security Awareness: Device Code Authorization
Copy link
Contributor

@Shellyber Shellyber Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::info Security Awareness: Device Code Authorization
info Security Awareness: Device Code Authorization

content-repo/extra-docs/articles/microsoft-auth-guide.md

For more information, see [Device Code flow - Evolved phishing](https://www.microsoft.com/security/blog/2022/01/26/evolved-phishing-device-registration-trick-adds-to-phishers-toolbox-for-victims-without-mfa/)

:::
Copy link
Contributor

@Shellyber Shellyber Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::

@content-bot
Copy link
Collaborator

content-bot commented Oct 23, 2025

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1809-m02g33qq.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@noydavidi noydavidi merged commit a27f65f into master Oct 23, 2025
8 checks passed
@noydavidi noydavidi deleted the align-ms-authentication-flows-docs branch October 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talihaff talihaff talihaff left review comments

@Shellyber Shellyber Shellyber approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

Assignees

@noydavidi noydavidi

Labels

docs-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@noydavidi @content-bot @talihaff @Shellyber