Hy/crtx 257330/standardized error messages#44952
Conversation
* Update CODEOWNERS * Update CODEOWNERS
* Initial release notes for sendmail-improve-arg-descriptions * Sync release notes from GitLab (2b0a285f) * Sync release notes from GitLab (e44aa7f8) * Bump pack from version Base to 1.41.86. * Sync release notes from GitLab (b0907a55) * Sync release notes from GitLab (1a47a9f6) * Sync release notes from GitLab (2b1af82f) * Sync release notes from GitLab (57884775) * update * Sync release notes from GitLab (895adb95) * Sync release notes from GitLab (8f5b7020) * Sync release notes from GitLab (143d8695) * Sync release notes from GitLab (c835b753) * Sync release notes from GitLab (c5d3930c) * Apply suggestion from @michal-dagan * Sync release notes from GitLab (28ff9f45) * Sync release notes from GitLab (28ff9f45) * Bump pack from version Base to 1.41.87. * Sync release notes from GitLab (5ded6563) * Sync release notes from GitLab (a9ea6345) * Sync release notes from GitLab (16ae301d) * Sync release notes from GitLab (e50879b3) * Sync release notes from GitLab (e50879b3) * Sync release notes from GitLab (63cf30aa) * Sync release notes from GitLab (23f07e48) * Sync release notes from GitLab (cdea5bd6) --------- Co-authored-by: CI Bot <ci@demisto.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: michal-dagan <mdagan@paloaltonetworks.com>
* Implement two-layer security for pickle deserialization across multiple scripts * Add tests for safe_pickle_loads and validate_pickle_opcodes * fix after pre-commit * reduce the duplicate code by moving logic to commonServerPython.py * Update line offset in _MODULES_LINE_MAPPING for CommonServerPython * update RN * fix build * Update and bump CommonScript RN * move tests to ommonserverpython_test * remove shared tests from each scripts * Refactor loading allowlists to extend a shared base across multiple scripts * fix test * fix pre-commit * Bump pack from version Base to 1.41.88. --------- Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: noydavidi <nodavidi.paloaltonetworks.com>
* property get and set * azure-storage-container-property-get * last commands updates * rn * added Enable Blob Soft Deletion and small fixes * ai review * ai review * ai review * ai review * pre-commit updates * fixed validation errors * ai review * removed deprecated context path
* Microsoftcommandsaddition (#44432) * Add google-drive-file-move and google-drive-file-create remediation commands * Revert formatting-only changes to non-Integration files per contribution policy * updating release pack release notes * changing the user id required paramater to false * changing the user id required paramater to false * adding field in response and set required to false * correcting naming conventions and following the patter * adding functionality to existing commands * Miplabelingcommands (#44315) * updated docker image * renamed name * fixed readme * adding microsoft 4 commands * fixed comments after ai review * fixing issue related to permission * removing unknown drive changes * Regenerate README for the 4 new driveItem commands after upstream merge * Apply markdownlint auto-fixes to README * adding readme review comment changes --------- Co-authored-by: noydavidi <nodavidi.paloaltonetworks.com> * in progress --------- Co-authored-by: ymishrapalo1992 <ymishra@paloaltonetworks.com> Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
…lys (#44451) * Add exposure_management to pack metadata * Fix Rns * Update Packs/CrowdStrikeFalcon/ReleaseNotes/2_11_3.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/CrowdStrikeFalcon/ReleaseNotes/2_11_3.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Rapid7_Nexpose/ReleaseNotes/1_4_2.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Rapid7_Nexpose/ReleaseNotes/1_4_2.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/qualys/ReleaseNotes/3_4_1.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Tenable_sc/ReleaseNotes/1_1_8.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/qualys/ReleaseNotes/3_4_1.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/qualys/ReleaseNotes/3_4_1.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Tenable_io/ReleaseNotes/2_3_26.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Tenable_sc/ReleaseNotes/1_1_8.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update Packs/Tenable_io/ReleaseNotes/2_3_26.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Bump outdated docker images to fix DO106 - Tenable_io: demisto/python3 -> 3.12.13.9059085 - Tenable_sc: demisto/python3 -> 3.12.13.9059085 - Rapid7_Nexpose: demisto/auth-utils -> 1.0.0.9224111 No pack version bump; appended a docker bullet to the existing in-progress release-notes entry of each pack. * Pin existing supportedModules on content items in EM-enabled packs Per CRTX-251868 build feedback: adding exposure_management to a pack's supportedModules causes content items that don't declare their own supportedModules to be implicitly extended to that scope too. For non- integration items we don't want that, so pin each one to the pack's pre-existing supportedModules list (the pack's list MINUS exposure_management). Prevents GR109/GR114 mismatches from firing. Touched 136 content items across Tenable_io, Tenable_sc, Rapid7_Nexpose, qualys, and CrowdStrikeFalcon (Playbooks, Scripts, ModelingRules, Classifiers, IncidentFields, IncidentTypes, Layouts). RN entries appended to each pack's already-open in-progress release-notes file. * Fix DO106 + BA103 + DS108 blockers surfaced by EM-pinning DO106 (docker image outdated): - 11 CrowdStrikeFalcon Scripts: demisto/python3:3.12.12.5490952 -> 3.12.13.9059085 - qualys/Scripts/QualysCreateIncidentFromReport: demisto/python3:3.12.8.3296088 -> 3.12.13.9059085 BA103 (malformed tests section): - 3 Rapid7_Nexpose JS Scripts (NexposeEmailParser, NexposeEmailParserForVuln, NexposeVulnExtractor): added 'tests: - No tests (auto formatted)'. DS108 (description without period): - NexposeEmailParser defaultNexposeSeverity argument description. These were pre-existing issues in the touched files, surfaced because the EM-pinning commit (e618bf0) put them in the PR diff. * Fix RN114 and RN107: split Classifiers/Mappers in CrowdStrikeFalcon 2_11_3.md The 5 mapper-type classifier files (CrowdStrike Falcon - Outgoing Mapper, 2x CrowdStrike Falcon Mapper, 2x Legacy CrowdStrike Falcon-Mapper) live under a separate '#### Mappers' heading per the validator; only 'CrowdStrike Falcon Incident Classifier' (the actual classification-type) stays under '#### Classifiers'. * Revert supportedModules pinning on non-platform content items Per BEAdi's review on #44451: content items whose effective marketplaces do not include 'platform' should not have a supportedModules block at all (supportedModules is a platform-only concept). The earlier blanket pinning commit (e618bf0) incorrectly added supportedModules to 110 xsoar-only items across 4 packs. Removed the supportedModules block from: - Rapid7_Nexpose: 2 playbooks (Vulnerability_Handling, Vulnerability_Management Job) - qualys: 2 playbooks (Vulnerability_Management Qualys Job + V2) - CrowdStrikeFalcon: 106 items (Classifiers/Mappers, IncidentFields, IncidentTypes, Layouts) - all xsoar-only Also removed the corresponding RN entries from each pack's in-progress release-notes file and collapsed any sections that became empty. Platform-supporting items in thesPlatform-supporting items in thesPlatform-supporting items in thesPlatform-supporting items in theppPlatform-supporting items in thesnePlatfosure_management entry. * Revert docker changes on items which are not platform * Add GR107/PB118/RM116 to .pack-ignore for EM-enabled packs * revert skipped validations * Trigger GitHub pipeline (user-created PR) * Trigger GitHub pipeline (user-created PR) --------- Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> Co-authored-by: CI Bot <ci@demisto.com>
* start * pre commit * pre commit and fix unit testing * Update Packs/SecurityScorecard/Integrations/SecurityScorecardEventCollector/README.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * ai reviewer comments fixes * code review fixes * little fix * add logo * fix validation * change first fetch * RN * rn * fix pack metadata --------- Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com>
* HY/CRTX-250066/bumpSlackVersionBatch4 * trigger build * ruff * slackV3 * validate no secrets * Remvoe slackV3v2 * fromversion: 5.5.0 * docker image
* Fix CID handling * Fix tests and ruff * Added release notes to apiModule and updated docker image
Co-authored-by: Content Bot <bot@demisto.com>
* Update Server URL parameter description in GuardiCore v2 * Update Packs/GuardiCore/Integrations/GuardiCoreV2/GuardiCoreV2.yml Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> --------- Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com>
…44479) * Tenable sc ingest - updated _time mapping and default fetch interval (#44458) * adding WIP code for Tenable.sc asset & vuln ingest * add time formatting and unit test failure * pre-commit hook updates * Remove Asset Modeling Rules * explicitly exclude WAS findings * fix failing test * ruff format * remove timestamp formatting * swap vuln _time mapping and use 12h default fetch interval w/ 1h min * fix failing test * update tag * rn * rn * rn * rn * rn * rn * rn * rn * fix ips * fix(tenable-sc): hide integration from agentix marketplace * fix(tenable-sc): remove invalid agentix value from hidden field --------- Co-authored-by: Andrew Scott <77340714+andrew-paloalto@users.noreply.github.com> Co-authored-by: yshamai <yshamai@paloaltonetworks.com> Co-authored-by: Yael Shamai <111040837+YaelShamai@users.noreply.github.com> Co-authored-by: Daniel Tal <dtal@paloaltonetworks.com>
* added the commands * ai-reviewer CR changes * fix validation * fix validation * Rename 4_1_1.md to 4_2_0.md * Update pack_metadata.json * Address review comments from @julieschwartz18 on PR #44364 * fix pre commit
* Rubrik Release 1.7.0 (#44132) * Rubrik Release 1.7.0 * Changes as per requested comments. * Changes as per requested comments. --------- Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> * Update the docker image and refine release notes * Revert docker image changes * Update the docker image --------- Co-authored-by: Crest Data <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: Kamal Qarain <kqarain@paloaltonetworks.com>
* CrwdStrike - improve memory consumption * diagnostic_mode=false and revert semaphore usage * revert to master + diagnostic_mode + 100-day filter + logs * fix test * readme + description * doc review + fix test playbook
* Update incidentfield-Rubrik_CDM_Cluster_Name.json * Restore incident field in XSOAR marketplace in Rubrik Security Cloud * Revert version bump
* Support adding multiple entries to client list in Akamai WAF (#44130) * feat(akamai): ✨ support adding multiple entries to client list - Updated the `akamai-add-client-list-entry` command to accept a comma-separated list of values. - Modified the implementation to handle multiple entries in a single API call. - Enhanced documentation and tests to reflect the new functionality. * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(akamai): ✨ add support for multiple client list entries * Updated `add_client_list_entry_command` to use `argToList` for `value` and `tags`. * Added validation to ensure at least one value is provided. * Enhanced README with command examples and human-readable output. * Updated `pack_metadata.json` to include relevant keywords. Co-authored-by: Copilot <copilot@github.com> * fix(akamai): address marketplace-ai-reviewer feedback - Add isArray: true to value argument for proper UI multi-select handling - Add test case for ValueError when value is empty - Fix README Command example header capitalization to lowercase * chore(contributors): ✏️ add Laura Sangeo Fontán to CONTRIBUTORS.json * Added a new contributor entry for Laura Sangeo Fontán. * chore(contributors): ✏️ fix typo in contributor name * Corrected the spelling of "Sangeao" in CONTRIBUTORS.json. * refactor: remove duplicate validation in add_client_list_entry method * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/README.md Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Update contributor entry for Laura Sangeao Fontán --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> * Fix pre-commit issues * Update Docker image --------- Co-authored-by: Laura Sangeao Fontán <103418101+laurasfo@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Marketplace AI reviewer <svc-mp-ai-reviewer@paloaltonetworks.com> Co-authored-by: Kamal Qarain <kqarain@paloaltonetworks.com> Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>
* VectraAI Release 2.1.4 (#44503) * VectraAI Release 2.1.4 * Updated as per provided comments --------- Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> * Update 2_1_4.md --------- Co-authored-by: Crest Data <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: Kamal Qarain <45042524+kamalq97@users.noreply.github.com>
…ndling (#44483) KOI: Add XSOAR marketplace support and graceful should_push_events handling
This comment has been minimized.
This comment has been minimized.
|
🤖 Analysis started. Please wait for results... |
🤖 AI Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
marketplace-ai-reviewer
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I've reviewed your changes and have a few quick updates for you to make. Please add the missing created key to the Core pack metadata. Additionally, since this PR introduces enhancements, both release notes need to be minor version bumps and should describe the actual functional changes instead of using the default fallback templates. Let me know if you have any questions!
Additionally, please address the following file-level notes:
Packs/Core/pack_metadata.json: The mandatory keycreatedis missing from the pack metadata.Packs/CommonScripts/ReleaseNotes/1_22_30.md: Version bump type mismatch: A minor bump is required for this enhancement.Packs/Core/ReleaseNotes/3_5_68.md: Version bump type mismatch: A minor bump is required for this enhancement.
@Shellyber, @jlevypaloalto, @hyaffe839 please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
This comment has been minimized.
This comment has been minimized.
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
This comment has been minimized.
This comment has been minimized.
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
🔍 AI Triage Report AvailableAn automated triage report has been generated for this pipeline. Status: 📋 Triage Report
|
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/CRTX-257330?
Description
Using ErrorCodes instead of generic ValueError/DemistoException
Must have