SLS - SCM GW Auth by TheL0L · Pull Request #44967 · demisto/content

TheL0L · 2026-07-06T12:59:16Z

Related Issues

fixes: CIAC-17092

Description

Implemented SCM GW authentication as a replacement for the deprecated OProxy authentication.

content-bot · 2026-07-06T13:00:38Z

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

@marketplace-ai-reviewer start review - Initiate a full AI code review
@marketplace-ai-reviewer re-review - Incremental review for new commits

github-actions · 2026-07-06T13:07:43Z

Coverage Report

File	Stmts	Miss	Cover	Missing
Packs/CortexDataLake/Integrations/CortexDataLake
CortexDataLake.py	701	282	59%	91–92, 198–202, 205–206, 209, 219, 227, 229, 235, 248–252, 255–257, 261, 272–273, 328–333, 335–337, 346–350, 352–353, 377, 379–381, 383, 398–402, 404–406, 409–412, 414–417, 424, 431–435, 437–442, 444, 447–449, 462–464, 573, 627, 687, 742, 933–938, 973–974, 1038, 1041, 1061, 1064, 1066–1068, 1107–1108, 1110, 1121, 1123, 1125, 1127–1129, 1131–1132, 1176–1180, 1263–1266, 1271–1275, 1359, 1376–1379, 1381–1382, 1384, 1386, 1388–1390, 1415, 1433–1436, 1438–1439, 1441, 1443, 1445–1447, 1462, 1479–1480, 1482–1484, 1486–1487, 1489, 1491, 1493–1495, 1504–1507, 1516–1519, 1540–1543, 1564–1567, 1583–1586, 1666–1668, 1670–1671, 1673–1675, 1678–1681, 1683–1685, 1687–1691, 1698–1700, 1702–1705, 1707, 1712–1716, 1718–1724, 1726–1729, 1731–1732, 1743–1745, 1755–1800, 1811–1815
TOTAL	701	282	59%

Tests	Skipped	Failures	Errors	Time
59	0 💤	0 ❌	0 🔥	3.326s ⏱️

marketplace-ai-reviewer · 2026-07-06T13:10:58Z

🤖 Analysis started. Please wait for results...

marketplace-ai-reviewer · 2026-07-06T13:50:26Z

🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

marketplace-ai-reviewer

Hi there, thanks for your updates to the Cortex Data Lake integration! I've left a few suggestions to help polish the code and documentation. Specifically, please improve the exception handling to preserve error context, ensure all deprecated OProxy parameters are fully hidden in the YAML configuration, and make a few minor metadata and release note styling tweaks. Thanks again for your hard work on this!

Additionally, please address the following file-level notes:

Packs/CortexDataLake/Integrations/CortexDataLake/CortexDataLake.yml: The PR description states that OProxy authentication is deprecated. While hidden: true was added to credentials_refresh_token, the other OProxy-related parameters (credentials_reg_id and credentials_auth_key) remain visible. Consider hiding them as well if they are no longer used.
Packs/CortexDataLake/Integrations/CortexDataLake/CortexDataLake_description.md: Move the ## Overview section and version-compatibility statement to the README.
Packs/CortexDataLake/pack_metadata.json: - The url field should be updated to https://www.paloaltonetworks.com/cortex.
Please add the vendor name (e.g., Palo Alto Networks) to the keywords array.
Please add "marketplacev2" to the marketplaces array.

@kamalq97, @TheL0L please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

content-bot · 2026-07-07T08:26:25Z

Validate summary
The following errors were thrown as a part of this pr: IN124, BA130.
The following errors can be ignored: IN124, BA130.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: IN124, BA130.

Verdict: PR can be force merged from validate perspective? ✅

content-bot · 2026-07-07T11:18:03Z

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 44371ea7e5037306

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

julieschwartz18

@TheL0L Doc review complete, minor edits. Please check the comments. In the meantime, adding the label docs-approved

julieschwartz18 · 2026-07-08T06:12:19Z

 1. In the War Room, run the command `!GetLicenseID` to get the `license ID`.
 2. Go to __Settings__ > __ABOUT__ > __License__ to get the `Customer Name`.
-3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and login using your **Palo Alto Networks** credentials. 
+3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and login using your **Palo Alto Networks** credentials.


Suggested change

3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and login using your **Palo Alto Networks** credentials.

3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and log in using your Palo Alto Networks credentials.

julieschwartz18 · 2026-07-08T06:15:33Z

 8. Click __Add instance__ to create and configure a new integration instance.
    * __Name__: A textual name for the integration instance.
-    * __Authentication Token__: From the authentication process
    * __Registration ID__: From the authentication process


Suggested change

* __Registration ID__: From the authentication process

* __Registration ID__: From the authentication process.

julieschwartz18 · 2026-07-08T06:17:54Z

-    * __Authentication Token__: From the authentication process
    * __Registration ID__: From the authentication process
       * The token retrieval URL is inferred based on the tenant's FedRAMP status unless explicitly specified in the __Registration ID__ parameter in the format `REGISTRATION_ID@URL`.
    * __Encryption Key__: From the authentication process


Suggested change

* __Encryption Key__: From the authentication process

* __Encryption Key__: From the authentication process.

julieschwartz18 · 2026-07-08T06:18:03Z

    * __Registration ID__: From the authentication process
       * The token retrieval URL is inferred based on the tenant's FedRAMP status unless explicitly specified in the __Registration ID__ parameter in the format `REGISTRATION_ID@URL`.
    * __Encryption Key__: From the authentication process
+    * __Client Secret__: From the authentication process


Suggested change

* __Client Secret__: From the authentication process

* __Client Secret__: From the authentication process.

julieschwartz18 · 2026-07-08T06:18:09Z

       * The token retrieval URL is inferred based on the tenant's FedRAMP status unless explicitly specified in the __Registration ID__ parameter in the format `REGISTRATION_ID@URL`.
    * __Encryption Key__: From the authentication process
+    * __Client Secret__: From the authentication process
    * __proxy__: Use system proxy settings


Suggested change

* __proxy__: Use system proxy settings

* __proxy__: Use system proxy settings.

julieschwartz18 · 2026-07-08T06:18:26Z

+    * __Client Secret__: From the authentication process
    * __proxy__: Use system proxy settings
    * __insecure__: Trust any certificate (not secure)
    * __Fetch incidents__: Whether to fetch incidents or not


Suggested change

* __Fetch incidents__: Whether to fetch incidents or not

* __Fetch incidents__: Whether to fetch incidents.

julieschwartz18 · 2026-07-08T06:18:35Z

    * __proxy__: Use system proxy settings
    * __insecure__: Trust any certificate (not secure)
    * __Fetch incidents__: Whether to fetch incidents or not
    * __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)


Suggested change

* __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)

* __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year).

julieschwartz18 · 2026-07-08T06:18:51Z

    * __insecure__: Trust any certificate (not secure)
    * __Fetch incidents__: Whether to fetch incidents or not
    * __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)
    * __Severity of events to fetch (Firewall)__: Select from all,Critical,High,Medium,Low,Informational,Unused


Suggested change

* __Severity of events to fetch (Firewall)__: Select from all,Critical,High,Medium,Low,Informational,Unused

* __Severity of events to fetch (Firewall)__: Select from all, Critical, High, Medium, Low, Informational, or Unused.

julieschwartz18 · 2026-07-08T06:20:51Z

    * __Fetch incidents__: Whether to fetch incidents or not
    * __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)
    * __Severity of events to fetch (Firewall)__: Select from all,Critical,High,Medium,Low,Informational,Unused
    * __Subtype of events to fetch (Firewall)__: Select from all,attack,url,virus,spyware,vulnerability,file,scan,flood,packet,resource,data,url-content,wildfire,extpcap,wildfire-virus,http-hdr-insert,http-hdr,email-hdr,spyware-dns,spyware-wildfire-dns,spyware-wpc-dns,spyware-custom-dns,spyware-cloud-dns,spyware-raven,spyware-wildfire-raven,spyware-wpc-raven,wpc-virus,sctp


Suggested change

* __Subtype of events to fetch (Firewall)__: Select from all,attack,url,virus,spyware,vulnerability,file,scan,flood,packet,resource,data,url-content,wildfire,extpcap,wildfire-virus,http-hdr-insert,http-hdr,email-hdr,spyware-dns,spyware-wildfire-dns,spyware-wpc-dns,spyware-custom-dns,spyware-cloud-dns,spyware-raven,spyware-wildfire-raven,spyware-wpc-raven,wpc-virus,sctp

* __Subtype of events to fetch (Firewall)__: Select from all, attack, url, virus, spyware, vulnerability, file, scan, flood, packet, resource, data, url-content, wildfire, extpcap, wildfire-virus, http-hdr-insert, http-hdr, email-hdr, spyware-dns, spyware-wildfire-dns, spyware-wpc-dns, spyware-custom-dns, spyware-cloud-dns, spyware-raven, spyware-wildfire-raven, spyware-wpc-raven, or wpc-virus,sctp.

julieschwartz18 · 2026-07-08T06:21:12Z

 3. After that every 60 minutes.

-If you wish to try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.
+If you wish to try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.


Suggested change

If you wish to try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.

To try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.

TheL0L added 3 commits July 6, 2026 13:50

implement SCM gateway auth, deprecate oproxy auth

729d3ca

update integration setup instructions

edb6b04

add release notes

0bb575b

TheL0L self-assigned this Jul 6, 2026

TheL0L requested a review from kamalq97 July 6, 2026 13:01

TheL0L added python Pull requests that update Python code ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jul 6, 2026

Merge branch 'master' into syakima/ciac-17092/sls-new-auth

ecaf871

marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jul 6, 2026

marketplace-ai-reviewer reviewed Jul 6, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

TheL0L added 3 commits July 7, 2026 10:44

improve exception handling

84ae2d0

format

039a29c

update docker image

9ca0363

TheL0L requested a review from richardbluestone July 7, 2026 08:14

TheL0L marked this pull request as ready for review July 7, 2026 10:17

richardbluestone requested review from julieschwartz18 and removed request for richardbluestone July 7, 2026 16:37

julieschwartz18 reviewed Jul 8, 2026

View reviewed changes

julieschwartz18 added the docs-approved label Jul 8, 2026

	3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and login using your Palo Alto Networks credentials.
	3. Go to the [HUB](https://apps.paloaltonetworks.com/apps) and log in using your Palo Alto Networks credentials.

	* __Registration ID__: From the authentication process
	* __Registration ID__: From the authentication process.

	* __Encryption Key__: From the authentication process
	* __Encryption Key__: From the authentication process.

	* __Client Secret__: From the authentication process
	* __Client Secret__: From the authentication process.

	* __proxy__: Use system proxy settings
	* __proxy__: Use system proxy settings.

	* __Fetch incidents__: Whether to fetch incidents or not
	* __Fetch incidents__: Whether to fetch incidents.

	* __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year)
	* __first_fetch_timestamp__: First fetch time (<number> <time unit>, e.g., 12 hours, 7 days, 3 months, 1 year).

	* __Severity of events to fetch (Firewall)__: Select from all,Critical,High,Medium,Low,Informational,Unused
	* __Severity of events to fetch (Firewall)__: Select from all, Critical, High, Medium, Low, Informational, or Unused.

	If you wish to try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.
	To try authenticating again, run the 'cdl-reset-authentication-timeout' command and retry.

Uh oh!

Conversation

TheL0L commented Jul 6, 2026

Related Issues

Description

Uh oh!

content-bot commented Jul 6, 2026

🤖 AI-Powered Code Review Available

Uh oh!

github-actions Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marketplace-ai-reviewer commented Jul 6, 2026

Uh oh!

marketplace-ai-reviewer commented Jul 6, 2026

Uh oh!

marketplace-ai-reviewer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

content-bot commented Jul 7, 2026

Uh oh!

content-bot commented Jul 7, 2026

🔍 AI Triage Report Available

Uh oh!

julieschwartz18 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 6, 2026 •

edited

Loading