Skip to content

Add a null check for res and res.Headers in HTTP script#44972

Open
MosheEichler wants to merge 4 commits into
masterfrom
HTTP-script-fix-header-does-not-exist
Open

Add a null check for res and res.Headers in HTTP script#44972
MosheEichler wants to merge 4 commits into
masterfrom
HTTP-script-fix-header-does-not-exist

Conversation

@MosheEichler

Copy link
Copy Markdown
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/XSUP-72401

Description

Improve the response headers handle to avoid failures

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler requested a review from DeanArbel July 7, 2026 07:24
@MosheEichler MosheEichler added release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. labels Jul 7, 2026
@content-bot

Copy link
Copy Markdown
Contributor

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @marketplace-ai-reviewer start review - Initiate a full AI code review
  • @marketplace-ai-reviewer re-review - Incremental review for new commits

@marketplace-ai-reviewer marketplace-ai-reviewer removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Jul 7, 2026
@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor

🤖 Analysis started. Please wait for results...

@marketplace-ai-reviewer

Copy link
Copy Markdown
Contributor
🤖 AI Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

@marketplace-ai-reviewer marketplace-ai-reviewer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the HTTP script! I've taken a look at your changes and left a couple of minor suggestions to improve the code's robustness. The main items are adding some basic error handling and array length checks in the JavaScript file, and fixing a small mismatch in the release notes header. Let me know if you have any questions!

@DeanArbel, @MosheEichler please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

Comment thread Packs/CommonScripts/ReleaseNotes/1_22_31.md Outdated
Comment thread Packs/CommonScripts/Scripts/Http/Http.js Outdated
@MosheEichler MosheEichler marked this pull request as ready for review July 7, 2026 07:57

@julieschwartz18 julieschwartz18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MosheEichler Doc review complete, minor edit in the release notes.

Comment thread Packs/CommonScripts/ReleaseNotes/1_22_31.md Outdated
Co-authored-by: julieschwartz18 <91824591+julieschwartz18@users.noreply.github.com>
@content-bot

Copy link
Copy Markdown
Contributor

Validate summary
The following errors were thrown as a part of this pr: DS108, BA103.
The following errors can be ignored: DS108.
The following errors cannot be ignored: BA103.
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.
The following errors don't run as part of the nightly flow and therefore can be force merged: DS108, BA103.

Verdict: PR can be force merged from validate perspective? ✅

@content-bot

Copy link
Copy Markdown
Contributor

🔍 AI Triage Report Available

An automated triage report has been generated for this pipeline.

Status: failed
Report ID: 8126b1bd4acd0b1d

📋 Triage Report
💡 Resolutions are available in the full report.

⚠️ AI-generated triage. Validate before acting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants