fix: support lists with separate metadata and data files in id_set #5150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed id_set generation crash when processing lists that store metadata and data in separate files. **Problem:** Lists can be stored as: - Unified: Single file with metadata + data - Separate: Metadata file (with 'id') + data file (no 'id') When processing separate data files, id_set generation crashed with AttributeError trying to sort entries with None keys. **Solution:** - Skip files without 'id' field in get_list_data(), return empty dict - Filter empty results in process_general_items() before appending - Added debug logging for skipped files **Impact:** - List metadata files correctly added to id_set - List data files safely skipped - Unified lists continue to work normally **Testing:** - Unit test: get_list_data() with unified/metadata/data files - Integration test: Full id_set generation with separate files - Verified crash before fix, success after
github-actions
bot
added
the
Contribution
|
Thank you for your contribution. Your willingness to improve our product and contribute to our community is highly appreciated. For your convenience, here is a link to the contributions SLAs document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#5149
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-15452
preventing formatter from corrupting JSON files in directories whose names
contain content type keywords.
Description
Fixed id_set generation crash when processing lists that store metadata and data in separate files.
Problem:
Lists can be stored as:
When processing separate data files, id_set generation crashed with AttributeError trying to sort entries with None keys.
Solution:
Impact:
Testing: