Fixes issue with interactive formatting #5164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Contribution
|
Thank you for your contribution. Your willingness to improve our product and contribute to our community is highly appreciated. For your convenience, here is a link to the contributions SLAs document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the format command, passing the assume option does not trigger the formatting to be conducted in interactive mode, despite the documentation:
"Assumes automatic yes/no as an answer to all prompts and runs non-interactively."
Underlying modules attempt to check for the interactive flag having been set (e.g. https://github.com/Anonymoo53/demisto-sdk/blob/1c9e31da20c2c87e546131158f8687b05b260c33/demisto_sdk/commands/format/update_playbook.py#L325); However, the assume-yes/no arguments do not trigger this to be happen.
This is a simple change to automatically set the interactive flag based upon whether the assume yes/no flag is set.
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-15445