Support for agents and actions from+to versions #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
omerKarkKatz
reviewed
Jan 5, 2026
...sdk/commands/validate/validators/BA_validators/BA106_is_from_version_sufficient_all_items.py
Outdated
Show resolved
Hide resolved
|
Changelog(s) in markdown:
|
omerKarkKatz
approved these changes
Jan 6, 2026
rshunim
requested changes
Jan 7, 2026
Contributor
rshunim
left a comment
rshunim
left a comment
There was a problem hiding this comment.
Hi @itssapir
Great work, I have 2 comments on your PR:
- when adding a new field to item, unfortunately we have 4 places to update. As you added in the schemas (for the format SDK command), the parser object, the strict_object for our ST110 validation and the fourth place is in the objects folder under content_graph (same hierarchy like parser and strict_objects)
- second, consider adding some UTs
rshunim
approved these changes
Jan 8, 2026
Contributor
rshunim
left a comment
rshunim
left a comment
There was a problem hiding this comment.
As I see AgentixBase in the graph objects inherits from ContentItem who has already the fields fromversion and toversion so approving your PR.
As I commented in the previous comment, if you see an option to add some UTs, don't hesitate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: CRTX-217425
Description
Add fromversion and toversion for Agentix items.