Skip to content

sk_cicd_reattach #5192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shmuel44 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

sk_cicd_reattach #5192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demisto_sdk/commands/download/downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ def verify_output_path(self, output_path: Path) -> bool:
)
return False

elif not output_path.parent.name == "Packs":
elif not output_path.parent.name in ("Packs", "SystemPacks"):
logger.error(
f"Error: Path '{output_path.absolute()}' is invalid.\n"
f"The provided output path for the download must be inside a 'Packs' folder. e.g., 'Packs/MyPack'."
Expand Down
8 changes: 4 additions & 4 deletions demisto_sdk/commands/upload/uploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,10 +543,10 @@ def __init__(
self.marketplace = marketplace

DETACH_ITEM_TYPE_TO_ENDPOINT: dict = {
"IncidentTypes": "/incidenttype/detach/:id/",
"Layouts": "/layout/:id/detach/",
"Playbooks": "/playbook/detach/:id/",
"Scripts": "/automation/detach/:id/",
"IncidentTypes": "/incidenttype/detach/:id",
"Layouts": "/layout/:id/detach",
"Playbooks": "/playbook/detach/:id",
"Scripts": "/automation/detach/:id",
}

VALID_FILES_FOR_DETACH = ["Playbooks", "Scripts", "IncidentTypes", "Layouts"]
Expand Down
Loading