Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2959309; Case 29516; undefined function base_path() - 8.x-1.x #3

Open
wants to merge 3 commits into
base: 8.x-1.x
Choose a base branch
from

Conversation

tashaharrison
Copy link

@tashaharrison tashaharrison commented Mar 26, 2018

Merged latest 8.x-1.x branch to the latest version.
Patch 1: https://www.drupal.org/project/domain/issues/2951511
Patch 2:

-    $this->path = $this->getScheme() . $this->getHostname() . base_path();
+    $this->path = $this->getScheme() . $this->getHostname() . $GLOBALS['base_path'];

@davidgrayston davidgrayston changed the base branch from 8.x-1.x to dennis-8.x-1.x April 3, 2018 18:30
@davidgrayston davidgrayston changed the base branch from dennis-8.x-1.x to 8.x-1.x April 3, 2018 18:30
@davidgrayston
Copy link
Contributor

Pushed latest 8.x-1.x

Switched base to dennis-8.x-1.x then back to 8.x-1.x to update the pull request diff

@davidgrayston
Copy link
Contributor

Create a new issue here: https://www.drupal.org/project/domain/issues/2959309

We need to update the issue once we have a better understanding of the cause

@davidgrayston davidgrayston changed the title 29516 8.x 1.x patched Issue 2959309; Case 29516; undefined function base_path() - 8.x-1.x Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants