-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/tools): add a subcommand --hide-stacktraces
for test
#24095
Open
Hajime-san
wants to merge
12
commits into
denoland:main
Choose a base branch
from
Hajime-san:add-test-subcommand-hide-traces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(cli/tools): add a subcommand --hide-stacktraces
for test
#24095
Hajime-san
wants to merge
12
commits into
denoland:main
from
Hajime-san:add-test-subcommand-hide-traces
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a couple comments. Sorry for the slow review.
cli/args/flags.rs
Outdated
@@ -2683,6 +2684,12 @@ Note: running multiple `deno test --clean` calls in series or parallel for the s | |||
.help("Select reporter to use. Default to 'pretty'.") | |||
.value_parser(["pretty", "dot", "junit", "tap"]) | |||
) | |||
.arg( | |||
Arg::new("hide-traces") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this option to --hide-stacktraces
?
remove unnecessary attribute Co-authored-by: Luca Casonato <[email protected]> Signed-off-by: Hajime-san <[email protected]>
--hide-traces
for test--hide-stacktraces
for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #24002
I implemented this suggestion that I think it sounds reasonable for reducing noise.
Also, this feature could hide stack trace when running test from editor with LSP command by internal code updated, however I don't touch it currently.
example
before
after