feat(cli/test): improve test output readability

[hukuuu]

Indent last line of tests that contain multiple steps.

Closes #24071

[CLAassistant]

All committers have signed the CLA.

[hukuuu]

@iuioiua after a but of struggle i think i managed to fix this. Couple of things to note:

1. The implementation breaks when tests have "parallel steps" for example, in cargo test test::steps_invalid_usage:

Deno.test("parallel steps with sanitizers", async (t) => {
  // not allowed because steps with sanitizers cannot be run in parallel
  const step1Entered = Promise.withResolvers<void>();
  const testFinished = Promise.withResolvers<void>();
  t.step("step 1", async () => {
    step1Entered.resolve();
    await testFinished.promise;
  });
  await step1Entered.promise;
  await t.step("step 2", () => {});
});

Produces

parallel steps with sanitizers ...
  step 1 ... INCOMPLETE
    step 2 ... FAILED (2ms)
  parallel steps with sanitizers ... FAILED (due to incomplete steps) (3ms)

I think its because of the TestEvents not firing properly ( because of how the deno test is written, step 1 waits for step 2, which should be invalid thing. I made the cargo test pass by touching the .out file

2. We now indent tests that have only output ( and no nested steps ):

sync pass todo ...
------- output -------
Warning: Not implemented: test.TestContext.todo
----- output end -----
  sync pass todo ... ok (3ms)

I am not sure if this looks better or worse.

What are your thoughts?

[iuioiua]

This doesn't seem like the correct approach. My understanding was that we just needed to prepend a couple of spaces, or increase description.level by 1, in the following lines:

deno/cli/tools/test/reporters/pretty.rs

Line 84 in 8d14a9d

"{}{} ...",

deno/cli/tools/test/reporters/pretty.rs

Line 361 in 8d14a9d

"{} {} ...",

Can you try that?

Also, looking at the output, I'm having 2nd thoughts on whether we should do the indent. Perhaps, just having the grayed text will suffice. Either way, let's see how it all looks 🙂

[hukuuu]

Following your suggestion verbatim doesnt produce the desired result. Couple of screenshots ( i have put an x in front just to make things easier to see )

Here is the test output of an example project i use to test this:

There are two problems here:

1. My understanding is that tests and steps should be indented if they have children. With your suggestion only steps are being indented.
2. All steps are being indented, instead of only those who have children

--

I think we must have a condition to understand wether a test/step is actually a parent. My best try to infer that is to see whether we are in a new line while printing the result. If the test/step doesnt have children, its result will be printed at the same line as the description ( self.is_new_line is false ). Conversely, if self.is_new_line is true, that means that the test/step in question is resuming the printing after its children have finished printing.

Maybe, another way to infer the same would be to peek at the child_results_buffer lenght.

EDIT: actually, checking if there is an entry in the child_results_buffer for the current test/step works as well, just tried it:

Also, even just to make things grey, i think the same inference should happen, otherwise pretty much all test output will become grey