Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate test itests #25512

Merged
merged 21 commits into from
Sep 16, 2024
Merged

chore: deprecate test itests #25512

merged 21 commits into from
Sep 16, 2024

Conversation

HasanAlrimawi
Copy link
Contributor

This PR is part of #22907

@HasanAlrimawi
Copy link
Contributor Author

Could you please check failing tests?
The issue is that the string "Check filename.js" doesn't appear on PR checks output, although it appears and succeeds locally.
What could be causing this difference?
@dsherret

dsherret
dsherret reviewed Sep 10, 2024
View reviewed changes
tests/specs/test/allow_all/__test__.jsonc Outdated
@@ -0,0 +1,5 @@
{
"args": "test --config ../../../config/deno.json --allow-all main.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment to #25558 (comment) , all spec tests should be self contained so we shouldn't be doing these relative paths to the ancestor directories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment here wasn't exactly accurate because yeah it's sometimes useful to use deno/std. We'll fix this in the future as part of #25561

dsherret
dsherret reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but we should look at getting rid of the traversal up ancestor directories. Ideally we shouldn't use files in the testdata directory except through remote modules.

@HasanAlrimawi
Copy link
Contributor Author

Thanks, but we should look at getting rid of the traversal up ancestor directories. Ideally we shouldn't use files in the testdata directory except through remote modules.

working on it...

dsherret
dsherret approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@dsherret dsherret enabled auto-merge (squash) September 16, 2024 08:45
@dsherret dsherret merged commit e0b9c74 into denoland:main Sep 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HasanAlrimawi @dsherret @bartlomieju