fix: do not panic running invalid file specifier #25530
Open
+136
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bartlomieju @dsherret |
…' into handle-invalid-path-error-denoland#20062
…' into handle-invalid-path-error-denoland#20062
…' into handle-invalid-path-error-denoland#20062
…' into handle-invalid-path-error-denoland#20062
… handle-invalid-path-error-denoland#20062 # Conflicts: # cli/graph_util.rs # cli/lsp/config.rs # runtime/permissions/lib.rs
dsherret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update prevents a panic in
specifier_to_file_pathon Windows by validating the file URL before callingto_file_path(). It ensures that:Paths are checked to be absolute and are converted if needed.
The path is verified to exist before passing it to
to_file_path(), ensuring invalid paths don't cause the application to crash.This fix gracefully handles invalid or non-standard file URLs, avoiding panics during path resolution.
fix #20056
Co-authored-by: Bedis Nbiba [email protected]