Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset signal pipe handler #28383

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

littledivy
Copy link
Member

Fixes #28338
Fixes #25258
Fixes #24529
Fixes #15767
Fixes #15045

@littledivy littledivy marked this pull request as draft March 4, 2025 04:30
@littledivy littledivy marked this pull request as ready for review March 4, 2025 04:44
@0f-0b
Copy link
Contributor

0f-0b commented Mar 4, 2025

This code currently throws a BrokenPipe error. Would it still be possible to handle the error after this change?

const listener = Deno.listen({ hostname: "::1", port: 0 });
listener.accept();

const conn = await Deno.connect({ hostname: "::1", port: listener.addr.port });
await conn.closeWrite();
await conn.write(new Uint8Array(1));

@littledivy
Copy link
Member Author

Yes, syscall EPIPE errors still work. Only stdio signal pipe errors go away with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants