Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): exclude npm workspace packages from graph roots in install #28401

Merged
merged 4 commits into from
Mar 5, 2025
Merged

fix(install): exclude npm workspace packages from graph roots in install #28401

merged 4 commits into from
Mar 5, 2025
+89 −2

Conversation

nathanwhit
Copy link
Member

Fixes #28374.

@nathanwhit nathanwhit requested a review from dsherret March 5, 2025 18:34
dsherret
dsherret reviewed Mar 5, 2025
View reviewed changes
dsherret
dsherret approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanwhit nathanwhit enabled auto-merge (squash) March 5, 2025 20:12
@nathanwhit nathanwhit merged commit 0c0757f into denoland:main Mar 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno install fails for private npm package in workspace
2 participants
@nathanwhit @dsherret