Skip to content

perf: faster timer #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: faster timer #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions core/runtime/jsruntime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2724,7 +2724,8 @@ impl JsRuntime {
let timers = match context_state.timers.poll_timers(cx) {
Poll::Ready(timers) => {
let traces_enabled = context_state.activity_traces.is_enabled();
let arr = v8::Array::new(scope, (timers.len() * 3) as _);
// todo(CyanChanges): give a zero-length array now, waiting for https://github.com/denoland/deno_core/pull/1163
let arr = v8::Array::new(scope, 0);
#[allow(clippy::needless_range_loop)]
for i in 0..timers.len() {
if traces_enabled {
Expand All @@ -2733,13 +2734,13 @@ impl JsRuntime {
.activity_traces
.complete(RuntimeActivityType::Timer, timers[i].0 as _);
}
// depth, id, function
let value = v8::Integer::new(scope, timers[i].1.1 as _);
arr.set_index(scope, (i * 3) as _, value.into());
let value = v8::Number::new(scope, timers[i].0 as _);
arr.set_index(scope, (i * 3 + 1) as _, value.into());
let value = v8::Local::new(scope, timers[i].1.0.clone());
arr.set_index(scope, (i * 3 + 2) as _, value.into());

let (id, depth, function) = (
v8::Number::new(scope, timers[i].0 as _),
v8::Integer::new(scope, timers[i].1.1 as _),
timers[i].1.0.open(scope),
);
function.call(scope, undefined, &[id.into(), depth.into()]);
}
arr.into()
}
Expand Down
Loading