Skip to content

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Oct 31, 2025

Part of the fix for denoland/deno#26136 -- this will allow us to tell we're doing a sync import and then to use a different executor for deno_graph that doesn't spawn the future in the tokio runtime.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 92.04545% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.70%. Comparing base (0c7f83e) to head (4cb60d0).
⚠️ Report is 357 commits behind head on main.

Files with missing lines Patch % Lines
core/modules/loaders.rs 68.75% 5 Missing ⚠️
core/modules/tests.rs 66.66% 1 Missing ⚠️
core/source_map.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   81.43%   79.70%   -1.74%     
==========================================
  Files          97      100       +3     
  Lines       23877    26048    +2171     
==========================================
+ Hits        19445    20761    +1316     
- Misses       4432     5287     +855     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the option bag

@dsherret dsherret merged commit 8cc7b59 into denoland:main Nov 3, 2025
18 checks passed
@dsherret dsherret deleted the feat_include_sync_load_options branch November 3, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants