fix: ignore already loaded js module #1221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: denoland/deno#30688
Summary
Deno currently panics when the same JavaScript module is loaded more than once, which can easily happen when using the
--preloadflag.For example:
What this PR does
This PR updates the module loading logic to ignore modules that have already been loaded, preventing duplicate imports and avoiding the panic.
Other Runtimes
Both Bun (
--preload) and Node.js (--import) already handle this case by skipping already loaded modules.