fix(shim-deno/std): Fix std not to use FsFile #98
Conversation
There was a problem hiding this comment.
Thanks for the PR @hyp3rflow! That's annoying that occurs in Node and I'm able to reproduce it. I think we need to do a few more changes to get this merged though.
| } | ||
| }); | ||
| return deferred.then((result) => { | ||
| process.stdin.pause(); |
There was a problem hiding this comment.
If someone does multiple read calls at once before the first is complete, would this pause the second call?
There was a problem hiding this comment.
In that code, yes. So I changed the logic to handle multiple calls correctly.
| p.fill(0); | ||
| process.stdin.resume(); | ||
| process.stdin.once("readable", () => { | ||
| const data = process.stdin.read(p.length) ?? process.stdin.read(); |
There was a problem hiding this comment.
Could falling back to read() cause more data to be read than what's in the buffer and then for p.set(data) to fail below with a RangeError?
There was a problem hiding this comment.
I think no.
The optional size argument specifies a specific number of bytes to read. If size bytes are not available to be read, null will be returned unless the stream has ended, in which case, all of the data remaining in the internal buffer will be returned.
If the size argument is not specified, all of the data contained in the internal buffer will be returned.
According to the documentation, if buffer has data more than p.length bytes, it doesn't fall back to stdin.read().
but buffer has data less than p.length bytes or is empty, stdin.read() will return all of the data contained in the buffer which is always less than p.length bytes.
|
Thanks for the kind review, @dsherret! |
| }); | ||
| return (prev = curr); | ||
| } as T; | ||
| } |
| process.stdin.on("error", onerror); | ||
| process.stdin.once("readable", () => { | ||
| process.stdin.off("error", onerror); | ||
| const data = process.stdin.read(p.length) ?? process.stdin.read(); |
There was a problem hiding this comment.
I think actually it's possible that between the process.stdin.read(p.length) and process.stdin.read() calls that stdin could receive more bytes than are in the buffer. Let's resolve it in a separate PR. I'll open an issue.
If node's "process" module is imported, accessing stdin by
fs.readthrowsEAGAINerror: resource temporarily unavailable.So I re-implemented std interface using
process.stdin,process.stdout,process.stderr.resolves #97