Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim help file #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add vim help file #119

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

created vim help file for #83 . I hope everything is correct.
If I should add more things to the help file please tell me.

@ghost ghost changed the title created vim style document txt for issue 83 created vim style document txt for #83 Apr 26, 2017
@blueyed
Copy link
Collaborator

blueyed commented Apr 26, 2017

vimhelplint reports some issues:

% VIMHELPLINT_VIM="nvim --headless" vimhelplint doc/deoplete-jedi.txt
doc/deoplete-jedi.txt:3:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:10:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:22:13:Error:2:A tag "deoplete-jedi" is duplicate with another in this file.
doc/deoplete-jedi.txt:41:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:56:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:65:41:Error:2:A tag "deoplete-jedi" is duplicate with another in this file.
doc/deoplete-jedi.txt:92:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:103:45:Error:4:A link "nvim-python-quickstart" does not have any corresponding tag.

@blueyed
Copy link
Collaborator

blueyed commented Apr 26, 2017

vimhelplint is from https://github.com/neomake/neomake/blob/master/contrib/vimhelplint.

With Neomake you can run :Neomake vimhelplint on the file (after make build/vimhelplint in Neomake's plugin dir).

@ghost
Copy link
Author

ghost commented Apr 26, 2017

I removed the error message but the warnings about the long lines are wrong.

The longest line in the file is 77 but vimhelplint still shows the warnings.

Seems the problem was with neomake.
Installed vimhelplint from https://github.com/machakann/vim-vimhelplint and warnings are gone.

@@ -100,4 +100,4 @@ Once you have created them, add the following to your vimrc file: >
let g:python_host_prog = '/full/path/to/neovim2/bin/python'
let g:python3_host_prog = '/full/path/to/neovim3/bin/python'

Note: deoplete only requires Python 3. See |nvim-python-quickstart|.
Note: deoplete only requires Python 3. See h: nvim-python-quickstart.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not work for me.
It seems to be provider-python in current Neovim - changed in neovim/neovim@37f560ae.

So it should be |provider-python| probably (assuming that 0.2.0 is released soonish).

@blueyed
Copy link
Collaborator

blueyed commented Apr 26, 2017

I do not get your last comment.
Are you saying that vimhelplint installed/used through Neomake's contrib script would get line lengths wrong?

@blueyed
Copy link
Collaborator

blueyed commented Apr 26, 2017

You might have been fooled by Vim's conceal feature to make *foo* into foo in help files (and therefore getting two columns less visually).

@blueyed blueyed changed the title created vim style document txt for #83 Add vim help file Apr 26, 2017
@zchee
Copy link
Member

zchee commented May 24, 2017

@blueyed Sorry for the late reply.
BTW, user is deleted account. but I think this pull request is very great work. So I want to merge, and fix your suggested point after the merge.
What do you think?

@blueyed
Copy link
Collaborator

blueyed commented May 24, 2017

@zchee
Yes, go ahead - but why not fix them by amending the commit right away then?

@zchee
Copy link
Member

zchee commented May 24, 2017

@blueyed Yeah, good idea.
But sorry... I don't have knowledge of vim help yet...😱
What meaning that warning result? #119 (comment)

@zchee
Copy link
Member

zchee commented May 24, 2017

@blueyed Ah, sorry. ghost said

I removed the error message but the warnings about the long lines are wrong.

So, now you suggested point is only of this?

You might have been fooled by Vim's conceal feature to make foo into foo in help files (and therefore getting two columns less visually).

@blueyed
Copy link
Collaborator

blueyed commented May 24, 2017

Remaining warnings are only about length:

doc/deoplete-jedi.txt:3:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:41:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:56:1:Warning:1:The width of a line should be no longer than 78.
doc/deoplete-jedi.txt:92:1:Warning:1:The width of a line should be no longer than 78.

Make sure to set conceallevel=0 when viewing those lines.

I would also use spaces instead of tabs throughout the file.

@zchee
Copy link
Member

zchee commented May 24, 2017

@blueyed

Remaining warnings are only about length:
Make sure to set conceallevel=0 when viewing those lines.

I see, Thanks. So, I should fix only of column length to less than 78, right?

I would also use spaces instead of tabs throughout the file.

got it.

BTW, Do we need magic comment such as these?
https://github.com/neomake/neomake/blob/43e6a4577aaa6e2fec0edc5ddf02180f9d574656/doc/neomake.txt#L697

@blueyed
Copy link
Collaborator

blueyed commented May 24, 2017

Not sure about the modeline ("magic line") - let's keep it.

@Shougo
Copy link
Collaborator

Shougo commented Sep 28, 2017

Why it is suspended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants