Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-search-input: remove state decorator from isTouched #1414

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Nov 19, 2024

Chromatic

https://stencil-search-input-tests--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

TODO: Test in vets-website

This should resolve the Stencil warning about re-renders.

Screenshot 2024-11-19 at 9 58 45 AM

closes department-of-veterans-affairs/vets-design-system-documentation#3539

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@jamigibbs jamigibbs added the patch Patch change in semantic versioning label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

va-search-input: Resolve Stencil test warning about isTouched re-rendering
1 participant