config file updates for rails 7 upgrade #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipDeFraties
changed the title
PhilipDeFraties
force-pushed
the
rails-7-app-update
branch
2 times, most recently
from
1ff6711 to
0ade33d
Compare
- Updated configuration files to align with Rails 7 defaults, many are just updating commented examples/instructions or replacing single quotes with double. - Updated Redis caching configuration in development and test environments. - remove sidekiq as queue adapted in env configs - Applied updates to logging, caching, and middleware configurations for improved performance and maintainability. - Updated schema.rb to reflect changes introduced by Rails 7, previously set precision values removed will be added back via migration in next commit
precision values were removed via app:update command as per rails 7 update va_facilities and visns tables previously had precision set to 11 which is outside the supported range of 0-6, so reimplementing with the max of 6
PhilipDeFraties
force-pushed
the
rails-7-app-update
branch
from
0ade33d to
7b06f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
https://agile6.atlassian.net/browse/DM-5358
Description - what does this code do?
Numerous updates to various config files via app:update command.
I went through and reviewed each file updated line by line, reverting changes that needed to be kept (ie keeping the settings for redis caching in the environment config files). Many changes were just adding/updating commented instructions and examples in the config files or replacing single quotes with double.
One notable change was the adding of default
precisionvalues for timestamp columns on in the schema, which unfortunately also removed the existingprecisionsettings that needed to be subsequently added back via migration in the second commit. Note: theva_facilitiesandvisnstables' timestamp columns were previously set to aprecisionof 11 which is (and was) outside the supported range of 0-6 so I reimplemented at the max of 6.Testing done - how did you test it/steps on how can another person can test it
CI + manual testing on DEV
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done