bug fix: innovation editor "Introduction" page #1157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
Description - what does this code do?
Fixes bug in which a query for
PracticePartnerPractice
s did not specifyinnovable_type
and so the return included all with aninnovable_id
that matched the given innovation's id, which could also include those belonging to aProduct
with the same id.Basically, if a
Practice
with the id of 1 had apractice_partner
that is also associated with aProduct
with id 1, thatpractice_partner
would appear twice as selections on the givenPractice
's "Introduction" page and would also be included in the params from the form submission and cause an error in theSavePracticeService
.This is not an issue in the
Product
editor workflow, where the query forPracticePartnerPractice
s are properly scoped.Testing done - how did you test it/steps on how can another person can test it
Tested on DEV (currently deployed) by deploying fix and verifying that the "Introduction" page for the "PRIDE" innovation persists updates without error.
Screenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done