Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: innovation editor "Introduction" page #1157

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Jan 15, 2025

JIRA issue link

Description - what does this code do?

Fixes bug in which a query for PracticePartnerPractices did not specify innovable_type and so the return included all with an innovable_id that matched the given innovation's id, which could also include those belonging to a Product with the same id.

Basically, if a Practice with the id of 1 had a practice_partner that is also associated with a Product with id 1, that practice_partner would appear twice as selections on the given Practice's "Introduction" page and would also be included in the params from the form submission and cause an error in the SavePracticeService.

This is not an issue in the Product editor workflow, where the query for PracticePartnerPractices are properly scoped.

Testing done - how did you test it/steps on how can another person can test it

Tested on DEV (currently deployed) by deploying fix and verifying that the "Introduction" page for the "PRIDE" innovation persists updates without error.

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties self-assigned this Jan 15, 2025
@PhilipDeFraties PhilipDeFraties merged commit 398cc76 into master Jan 15, 2025
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the innovation-intro-page-fix branch January 15, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant