Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptions page fix #1158

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Jan 16, 2025

Description - what does this code do?

updates nginx config with increased values for buffer size and body size

adds eager loading to DiffusionHistory:by_status scope to alleviate N+1 query identified by the bullet gem on the "adoptions" page of the innovation editor

Testing done - how did you test it/steps on how can another person can test it

Tested locally and on DEV

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties changed the title update DiffusionHistory:by_status scope to eager load diffusion_histo… adoptions page fix Jan 16, 2025
@PhilipDeFraties PhilipDeFraties force-pushed the innovation-editor-adoptions-page-fix branch from 8160884 to 14f7077 Compare January 16, 2025 21:07
@PhilipDeFraties PhilipDeFraties force-pushed the innovation-editor-adoptions-page-fix branch from 14f7077 to 8802f95 Compare January 16, 2025 21:34
@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review January 16, 2025 21:36
@PhilipDeFraties PhilipDeFraties merged commit c0125e7 into master Jan 16, 2025
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the innovation-editor-adoptions-page-fix branch January 16, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant