Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dm 4693 add edit button to PB editor page #856

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Apr 22, 2024

JIRA issue link

https://agile6.atlassian.net/browse/DM-4693

Description - what does this code do?

Updates editor/pages config:

  1. removes redundant as: "Pages from main block
  2. removes config.clear_action_items! - I originally thought that had to be included to remove download buttons
  3. removes now-redundant action_item button for new page

Testing done - how did you test it/steps on how can another person can test it

  1. As admin or page_group editor visit /editor
  2. Verify there is a "New Page" button in the top left
  3. For a page click "View"
  4. Verify there are "Edit Page" and "Delete Page" buttons in the top left

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Sorry, something went wrong.

removes redundant `as: 'Pages'`

remove `config.clear_action_items!`

remove redundant action_item button for new page
@PhilipDeFraties PhilipDeFraties force-pushed the dm-4693-add-edit-button-to-editor-page branch from 5f6fba0 to 4b49463 Compare April 22, 2024 17:40
@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review April 22, 2024 17:40
@camillevilla camillevilla changed the title Dm 4693 add edit button to editor page Dm 4693 add edit button to PB editor page Apr 22, 2024
@camillevilla camillevilla merged commit a54538c into master Apr 22, 2024
5 of 6 checks passed
@camillevilla camillevilla deleted the dm-4693-add-edit-button-to-editor-page branch April 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants