dm-4749 add user roles to report #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds "Admin" and "PageGroup Editor Roles" rows to show config block
adds csv block with selected columns and added "Admin" and "PageGroup Editor Roles" columns
returns page_group names for "PageGroup Editor Roles" row and column in show and csv configs
camillevilla
approved these changes
May 9, 2024
Code Scanning Policy FindingsYour repository contains unresolved code scanning alerts. Policy requires that all code scanning alerts ofcritical severity be resolved within 30 days.In the future, if your repository contains unresolved code scanning alerts older than 30 days, you will not be able to merge this pull request. Learn more about how to triage and remediate these alerts in the GitHub Code Scanning documentation. If this pull request remediates these alerts, after your pull requests CodeQL scan has completed, follow this link to re-run the policy check and select Re-run all jobs at the top of the page: https://github.com/department-of-veterans-affairs/diffusion-marketplace/actions/runs/9023935996You may also re-run this required check by simply commenting on this pull request with the following command: /actions-bot rerun-required-workflows
|
camillevilla
approved these changes
May 9, 2024
PhilipDeFraties
added a commit
that referenced
this pull request
May 9, 2024
* update admin/users adds "Admin" and "PageGroup Editor Roles" rows to show config block * update admin/users adds csv block with selected columns and added "Admin" and "PageGroup Editor Roles" columns * update admin/users returns page_group names for "PageGroup Editor Roles" row and column in show and csv configs * update comment in admin/users form * update admin_spec feature test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue link
https://agile6.atlassian.net/browse/DM-4749
Description - what does this code do?
showconfiguration foradmin/usersTesting done - how did you test it/steps on how can another person can test it
page_groupsadmin/userspage (/admin/users/{id})you see the "PageGroup Editor Roles" row with the names of thepage_groups the user is an editor for listed:adminrole for the user.admin/userspages and utilize "Download: CSV" button to the bottom left of the indexScreenshots, Gifs, Videos from application (if applicable)
Link to mock-ups/mock ups (image file if you have it) (if applicable)
Acceptance criteria
Definition of done