Fed engineer PR reviewer checklist #104285
Open
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-oddball
approved these changes
Mar 7, 2025
| - [ ] I understand I can reach out in the CoP Slack channel with PR questions. | ||
|
|
||
| ## Approval | ||
| - [ ] Approved by Bill Chapman |
There was a problem hiding this comment.
I wonder if we shouldn't same something like Approved by OCTO Leadership or something like that. I could see Bill being one of the main approvers but most likely not the only one?
Or, maybe leave as is for now and we can see how it flows and adjust later if we believe it needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed issue template for federal engineers to fill out before becoming PR approvers.
The idea for this came up at a team lead meeting (meeting notes) and then also brought up at the CoP meeting. Definitely open to feedback!