Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Removes Sidekiq Enterprise and Pro dependencies Removes enterprise-specific Sidekiq gems and their dependencies (einhorn, gserver) to simplify the application's job processing infrastructure and reduce external dependencies. * Adds UserAuditLogger service and specs This commit introduces a new UserAuditLogger service for tracking user actions and their verification statuses. The implementation includes: The UserAuditLogger provides functionality to: - Log user actions with verification status - Support custom status messages - Handle missing verification cases - Maintain consistent logging format Files changed: - app/services/user_audit_logger.rb - spec/services/user_audit_logger_spec.rb - .github/CODEOWNERS * Removes trailing whitespace from Ruby files * refactor(user-audit-logger): Convert to service object pattern - Convert to instance class with initialize/perform pattern - Accept verification objects directly instead of user objects - Remove default status, require explicit status value - Add validations for required fields - Use config hash to fix parameter list length - Pass UserActionEvent object instead of ID The UserAuditLogger now follows service object conventions and has stricter parameter requirements for better reliability. * Use implicit arguments and consistent naming * refactor: simplify UserAuditLogger specs and improve initialization - Replace config hash with explicit keyword arguments in UserAuditLogger initialization - Move status to a top-level let declaration for better test organization - Update error message for subject verification to be more precise - Update missing parameter test to match Ruby's actual ArgumentError message - Remove redundant logger initialization in specs * refactor: improve UserAuditLogger initialization and specs - Update UserAuditLogger to use explicit keyword arguments Co-authored-by: bramleyjl * revert: remove Gemfile.lock changes The Gemfile.lock changes were unintentionally included in commit 1255301. These changes should be handled separately. * revert: remove Gemfile.lock changes The Gemfile.lock changes were unintentionally included in commit 1255301. These changes should be handled separately. * improve UserAuditLogger parameter handling - Keep explicit parameters in initialize for better code clarity - Add inline rubocop disable for ParameterLists - Update error message for subject verification - Use implicit hash syntax consistently - Remove redundant status testing - Remove unnecessary config variable The initialize method intentionally keeps all parameters explicit to make it clear what the class requires, with a rubocop disable comment to acknowledge the parameter count. * Improves Rubocop directive placement
- Loading branch information