Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8: [ART] POA request representative #20009

Draft
wants to merge 2 commits into
base: art/poa-requests/part-5/representatives.2
Choose a base branch
from

Conversation

nihil2501
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 23, 2024

2 Errors
🚫 This PR changes 794 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • app/models/accredited_individual.rb (+5/-0)

  • app/models/accredited_organization.rb (+5/-0)

  • db/schema.rb (+15/-6)

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb (+11/-2)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+33/-5)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb (+22/-2)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb (+18/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb (+0/-18)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb (+0/-4)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb (+0/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb (+20/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/accredited_individual_serializer.rb (+14/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/decision_serializer.rb (+21/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/expiration_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/power_of_attorney_holder_serializer.rb (+27/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/resolution_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212839_remove_old_indices_from_poa_forms.rb (+6/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212922_remove_columns_from_poa_forms.rb (+5/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212942_add_columns_to_poa_forms.rb (+10/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213018_add_new_index_to_poa_forms.rb (+8/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213059_add_claimant_type_to_poa_requests.rb (+5/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213060_add_poa_request_references_representatives.rb (+20/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213061_add_poa_request_references_representatives_foreign_key.rb (+5/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213062_add_poa_request_references_representatives_foreign_key_validate.rb (+5/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+53/-4)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb (+3/-0)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+350/-66)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/schema.rb

  • modules/accredited_representative_portal/db/migrate/20241227212839_remove_old_indices_from_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227212922_remove_columns_from_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227212942_add_columns_to_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227213018_add_new_index_to_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227213059_add_claimant_type_to_poa_requests.rb

  • modules/accredited_representative_portal/db/migrate/20241227213060_add_poa_request_references_representatives.rb

  • modules/accredited_representative_portal/db/migrate/20241227213061_add_poa_request_references_representatives_foreign_key.rb

  • modules/accredited_representative_portal/db/migrate/20241227213062_add_poa_request_references_representatives_foreign_key_validate.rb

    App File(s)

    • app/models/accredited_individual.rb
  • app/models/accredited_organization.rb

  • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/accredited_individual_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/decision_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/expiration_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/power_of_attorney_holder_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/resolution_serializer.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.3/main/main December 23, 2024 16:58 Inactive
@nihil2501 nihil2501 changed the title [ART] POA request representative 8: [ART] POA request representative Dec 23, 2024
@nihil2501 nihil2501 force-pushed the art/poa-requests/part-5/representatives.2 branch from 3150e8c to 4adfce0 Compare December 31, 2024 02:14
@nihil2501 nihil2501 force-pushed the art/poa-requests/part-5/representatives.3 branch from 0af5f56 to a718cb2 Compare December 31, 2024 02:24
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives.3/main/main December 31, 2024 02:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants