Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VABC Migration to add UserAccount to SavedClaim #20010

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mreed101
Copy link
Contributor

This change creates a migration that adds a user account foreign key to saved claim. This is an optional field for saved claim that can be utilized during submission

Summary

  • This work is behind a feature toggle (flipper): NO
  • No changes to the platform... but obviously this is a migration
  • Not a bug
  • This was requested was made so that it is easier to find a users information for a submitted claim
  • Benefits and claims
  • No flipper

Related issue(s)

  • Ticket
  • Link to previous change of the code/bug (if applicable) - N/A
  • Link to epic if not included in ticket - N/A

Testing done

  • New code is covered by unit tests
  • Saved claim previously did not have a user account that could be added to it
  • Run the migration, check for a new column in saved_claim called user_account_id
  • If this work is behind a flipper: No
    • Tests need to be written for both the flipper on and flipper off scenarios. Test were written to see if a user account could be added
    • What is the testing plan for rolling out the feature? Not a new feature

What areas of the site does it impact?

It will touch all saved claims

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to vabc/jr/user-info-to-saved-claim-84546/main/main December 23, 2024 17:40 Inactive
Copy link

1 Error
🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/migrate/20241216175516_add_user_account_to_saved_claims.rb

  • db/schema.rb

    App File(s)

    • .github/CODEOWNERS
  • app/models/saved_claim.rb

  • spec/models/saved_claim_spec.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to vabc/jr/user-info-to-saved-claim-84546/main/main December 23, 2024 18:01 Inactive
@micahaspyr
Copy link
Contributor

@mreed101 In the testing checks above, the danger/danger check failed. It's pretty strange, but the gods that be only want two file changes in a migration. So only submitting these two files should make it pass

  • db/migrate/20241216175516_add_user_account_to_saved_claims.rb
  • db/schema.rb

@mreed101 mreed101 marked this pull request as ready for review January 7, 2025 14:02
@mreed101 mreed101 requested review from a team as code owners January 7, 2025 14:02
@mreed101 mreed101 marked this pull request as draft January 7, 2025 14:05
@va-vfs-bot va-vfs-bot temporarily deployed to vabc/jr/user-info-to-saved-claim-84546/main/main January 7, 2025 14:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vabc/jr/user-info-to-saved-claim-84546/main/main January 7, 2025 20:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants