Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-894 - handle 404 error for 22-10203 SCO email #20025

Merged
merged 2 commits into from
Dec 30, 2024
Merged

VEBT-894 - handle 404 error for 22-10203 SCO email #20025

merged 2 commits into from
Dec 30, 2024

Conversation

GcioGregg
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • VEBT-894 - handle 404 error for 22-10203 SCO email
  • (If bug, how to reproduce) N/A
  • add error handling
  • VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

From ticket:
Description

Fixing a school certifying officials email datadog error. The error is /app/lib/common/client/base.rb:115:in `rescue in request': BackendServiceException: {:status=>404, :detail=>"Record not found", :code=>"GI404", :source=>"Record not found"} (GI::ServiceException)

Testing done

  • New code is covered by unit tests
  • 404 error thrown for SCO email when facility code is not an approved institution
  • submit a 10203 form

What areas of the site does it impact?

submission of 10203 form SCO email

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)

Copy link
Contributor

@nfstern02 nfstern02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to send a message to the front end when this happens? Approved either way.

@GcioGregg GcioGregg merged commit 50ff732 into master Dec 30, 2024
21 of 22 checks passed
@GcioGregg GcioGregg deleted the vebt-894 branch December 30, 2024 22:30
derekhouck pushed a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants