Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent facilities endpoint enhancements - Filter by type of care #20026

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JunTaoLuo
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES - va_online_scheduling_recent_locations_filter
  • This is part of ongoing development for the new recent locations feature. This PR adds an optional url param clinical_service_id that allows recent facilities endpoint to filter returned facilities to only those that supports the specified service.
  • Appointment (VAOS) Team

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Added new unit tests to cover the added filter capability and ensured existing tests pass

Screenshots

N/A

What areas of the site does it impact?

Appointments (VAOS)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@JunTaoLuo JunTaoLuo force-pushed the jtluo/filter-type-of-care branch from 9e9bb83 to 0549177 Compare December 24, 2024 22:06
@va-vfs-bot va-vfs-bot temporarily deployed to jtluo/filter-type-of-care/main/main December 24, 2024 22:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants