Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6: [ART] Skip spec for POA request representatives migration #20039

Draft
wants to merge 3 commits into
base: art/poa-requests/part-3/migrations.2
Choose a base branch
from

Conversation

ojbucao
Copy link
Contributor

@ojbucao ojbucao commented Dec 27, 2024

No description provided.

Copy link

github-actions bot commented Dec 27, 2024

2 Errors
🚫 This PR changes 617 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • db/schema.rb (+9/-6)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb (+33/-5)

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb (+18/-1)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb (+18/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb (+0/-18)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb (+0/-4)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb (+0/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb (+10/-6)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/decision_serializer.rb (+21/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/expiration_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/resolution_serializer.rb (+7/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212839_remove_old_indices_from_poa_forms.rb (+6/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212922_remove_columns_from_poa_forms.rb (+5/-0)

  • modules/accredited_representative_portal/db/migrate/20241227212942_add_columns_to_poa_forms.rb (+10/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213018_add_new_index_to_poa_forms.rb (+8/-0)

  • modules/accredited_representative_portal/db/migrate/20241227213059_add_claimant_type_to_poa_requests.rb (+5/-0)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb (+53/-4)

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb (+1/-0)

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb (+290/-66)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/schema.rb

  • modules/accredited_representative_portal/db/migrate/20241227212839_remove_old_indices_from_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227212922_remove_columns_from_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227212942_add_columns_to_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227213018_add_new_index_to_poa_forms.rb

  • modules/accredited_representative_portal/db/migrate/20241227213059_add_claimant_type_to_poa_requests.rb

    App File(s)

    • modules/accredited_representative_portal/app/controllers/accredited_representative_portal/v0/power_of_attorney_requests_controller.rb
  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_form.rb

  • modules/accredited_representative_portal/app/models/accredited_representative_portal/power_of_attorney_request.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/application_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_decision_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_expiration_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_resolution_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/decision_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/expiration_serializer.rb

  • modules/accredited_representative_portal/app/serializers/accredited_representative_portal/power_of_attorney_request_serializer/resolution_serializer.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_form.rb

  • modules/accredited_representative_portal/spec/factories/power_of_attorney_request.rb

  • modules/accredited_representative_portal/spec/requests/accredited_representative_portal/v0/power_of_attorney_requests_spec.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives/main/main December 27, 2024 04:18 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch from d25e8f0 to 9ead4aa Compare December 27, 2024 07:05
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives branch from 2c6144b to 3d6db2c Compare December 27, 2024 19:54
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives/main/main December 27, 2024 20:02 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch 3 times, most recently from 5e4c619 to 4284620 Compare December 30, 2024 16:48
@ojbucao ojbucao force-pushed the art/poa-requests/part-5/representatives branch from a2284b3 to 9784633 Compare December 30, 2024 17:50
@va-vfs-bot va-vfs-bot temporarily deployed to art/poa-requests/part-5/representatives/main/main December 30, 2024 17:54 Inactive
@ojbucao ojbucao force-pushed the art/poa-requests/part-3/migrations.2 branch from 4284620 to 672fcff Compare December 31, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants