-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toxic Exposure: Toggle clean up in BE #20043
base: master
Are you sure you want to change the base?
Conversation
…6_toxic_exposure, disability_526_toxic_exposure_ipf and disability_526_toxic_exposure_document_upload_polling flags
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
# expect(response).to have_http_status(:ok) | ||
# json_response = JSON.parse(response.body) | ||
# expect(json_response['formData']['startedFormVersion']).to eq(nil) | ||
# end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik we shouldn't be seeing claims anymore with a nil or empty startedFormVersion. if we have good coverage for both the 2019 and 2022 scenarios we may be able to remove these types of tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @christinec-fftc . removed the commented tests and changed some verbiage around
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/requests/v0/disability_compensation_in_progress_forms_controller_spec.rb |
Removing disability526_toxic_exposure, disability_526_toxic_exposure_ipf and disability_526_toxic_exposure_document_upload_polling flags
Summary
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?