Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-918] Updating UserVerifier to take distinct attributes, and to properly propagate mhv uuid #20046

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Dec 27, 2024

Summary

  • This PR updates UserVerifier functionality so that MHV accounts will properly propagate the MHV UUID when the UserVerifier is called during an MHV SSOe auth

Related issue(s)

Testing done

  • This refactored general UserVerifier functionality, so confirmed that SiS and SSOe authentications still create an appropriate UserVerification in the UserVerifier code
  • Confirmed using Mocked Authentication that MHV authentication created a UserVerification

What areas of the site does it impact?

Authentication

Acceptance criteria

  • Confirm authenticating with Sign in Service and SSOe still result in a UserVerification getting created or updated when appropriate
  • MHV SSOe Auth is difficult to test localhost, so will have to wait until staging to test

@bosawt bosawt requested a review from a team as a code owner December 27, 2024 21:35
@va-vfs-bot va-vfs-bot temporarily deployed to vi_918_mhv_ssoe_auth_user_verification/main/main December 27, 2024 21:45 Inactive
@bosawt bosawt force-pushed the vi_918_mhv_ssoe_auth_user_verification branch from a95b59f to 275cb1e Compare December 27, 2024 22:06
@va-vfs-bot va-vfs-bot temporarily deployed to vi_918_mhv_ssoe_auth_user_verification/main/main December 27, 2024 22:07 Inactive
@bosawt bosawt force-pushed the vi_918_mhv_ssoe_auth_user_verification branch from 275cb1e to af72d43 Compare December 27, 2024 22:10
@va-vfs-bot va-vfs-bot temporarily deployed to vi_918_mhv_ssoe_auth_user_verification/main/main December 27, 2024 22:16 Inactive
Copy link
Contributor

@bramleyjl bramleyjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed SSOe & SiS UserVerification creation still functions.

Looks good other than the one comment about removing the user_verifier_object creation in SiS.

app/services/sign_in/user_code_map_creator.rb Show resolved Hide resolved
@bosawt bosawt force-pushed the vi_918_mhv_ssoe_auth_user_verification branch 2 times, most recently from 51e28c5 to a9b39ea Compare December 31, 2024 21:18
@bosawt bosawt requested a review from bramleyjl December 31, 2024 21:20
@va-vfs-bot va-vfs-bot temporarily deployed to vi_918_mhv_ssoe_auth_user_verification/main/main December 31, 2024 21:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants