Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pension submitted email #20350

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Pension submitted email #20350

merged 4 commits into from
Jan 21, 2025

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Jan 17, 2025

Summary

  • This work is behind a feature toggle (flipper): YES
  • Send an email notifying applicants that their Pension application was submitted on VA.gov, replacing the current confirmation email.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Submitted a Pension claim with flipper on and confirmed the "submitted" email appeared in the ClaimVANotification table
  • Submitted a Pension claim with flipper off and confirmed the "confirmation" email appeared in the ClaimVANotification table

What areas of the site does it impact?

Pensions

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to pension-submitted-email/main/main January 17, 2025 18:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-submitted-email/main/main January 17, 2025 19:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to pension-submitted-email/main/main January 21, 2025 17:45 Inactive
balexandr
balexandr previously approved these changes Jan 21, 2025
@@ -219,6 +223,15 @@ def send_confirmation_email
@pension_monitor.track_send_confirmation_email_failure(@claim, @intake_service, @user_account_uuid, e)
end

##
# VANotify job to send Submission in Prorgess email to veteran
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo but not super important

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@TaiWilkin TaiWilkin force-pushed the pension-submitted-email branch from a31c66c to be1ead2 Compare January 21, 2025 17:54
@TaiWilkin TaiWilkin requested a review from balexandr January 21, 2025 18:01
@TaiWilkin TaiWilkin marked this pull request as ready for review January 21, 2025 18:01
@TaiWilkin TaiWilkin requested review from a team as code owners January 21, 2025 18:01
@TaiWilkin TaiWilkin merged commit 56a2453 into master Jan 21, 2025
43 of 44 checks passed
@TaiWilkin TaiWilkin deleted the pension-submitted-email branch January 21, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants