Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create model definitions and user associations for #20426
Create model definitions and user associations for #20426
Changes from 32 commits
7b12db4
0aaffe6
b393e7a
94d9f03
552b0bc
cd6726d
e58d829
730a5f3
5e2fe0c
cbb595a
983d55e
f808fd9
253c49a
a61d5b7
c14762b
ae87744
67b1152
4c07eca
bf0d1cd
5bad0b4
4018b79
e5a1c81
84966c5
18d9edd
4079baa
b52b1fa
a77928a
735815c
4132401
5c2ea8b
ae72e4e
8b16433
a5a3649
d2a83ab
4467434
1422228
4bfa55f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pluralize these:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think it’s necessary to test attribute validations unless they are explicitly defined in the model. These will be valid regardless of whether they are
nil
or not.