Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-43688] 526 - Validation for activeDutyEndDate beyond 180 days #20558

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

tycol7
Copy link
Contributor

@tycol7 tycol7 commented Jan 31, 2025

Summary

In v1 526, validate that at least one service period activeDutyEndDate is within 180 days from the current date.

Update v1 and v2 docs to include requirement:

Date Completed Active Duty. If in the future, 'separationLocationCode' is required. Cannot be more than 180 days in the future, unless past service is also included.

Related issue(s)

API-43688

Testing done

  • New code is covered by unit tests

Screenshots

v1
v1

v2
v2

What areas of the site does it impact?

526 v1 submission validation. v1 and v2 docs.

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

N/A

@tycol7 tycol7 added the claimsApi modules/claims_api label Jan 31, 2025
@va-vfs-bot va-vfs-bot temporarily deployed to push-xpzztzokyksq/main/main January 31, 2025 20:22 Inactive
@tycol7 tycol7 marked this pull request as ready for review January 31, 2025 21:42
@tycol7 tycol7 requested a review from a team as a code owner January 31, 2025 21:42
@va-vfs-bot va-vfs-bot temporarily deployed to push-xpzztzokyksq/main/main February 1, 2025 02:34 Inactive
@tycol7 tycol7 requested review from cilestin and a team February 3, 2025 17:09
@tycol7 tycol7 enabled auto-merge (squash) February 3, 2025 17:13
@va-vfs-bot va-vfs-bot temporarily deployed to push-xpzztzokyksq/main/main February 3, 2025 18:22 Inactive
@tycol7 tycol7 merged commit f738008 into master Feb 3, 2025
30 checks passed
@tycol7 tycol7 deleted the push-xpzztzokyksq branch February 3, 2025 23:54
bramleyjl pushed a commit that referenced this pull request Feb 10, 2025
…20558)

* validate active duty end date within 180 days

* update docs

* add end_of_day
holdenhinkle pushed a commit that referenced this pull request Feb 12, 2025
…20558)

* validate active duty end date within 180 days

* update docs

* add end_of_day
patrick-brown-oddball pushed a commit that referenced this pull request Feb 17, 2025
…20558)

* validate active duty end date within 180 days

* update docs

* add end_of_day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api test-passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants